dism resource: add sourcePath parameter to allow for offline feature installs by Alex-shearing · Pull Request #1561 · PowerShell/DSC

Alex-shearing · 2026-06-05T09:35:41Z

To allow Windows optional features and feature on demand installs on Windows computers without internet access, the source paramter must be accessible to supply offline resources.

This is available as the 'Source' paramter in:

Install-WindowsFeature PowerShell CmdLet: https://learn.microsoft.com/en-us/powershell/module/servermanager/install-windowsfeature?view=windowsserver2025-ps
Enable-WindowsOptionalFeature PowerShell CmdLet: https://learn.microsoft.com/en-us/powershell/module/dism/enable-windowsoptionalfeature?view=windowsserver2025-ps
WindowsFeatureSet PowerShell DSC Resource: https://learn.microsoft.com/en-us/powershell/dsc/reference/resources/windows/windowsfeaturesetresource?view=dsc-1.1

The changes include:

Add sourcePath property to Microsoft.Windows/FeatureOnDemandList and Microsoft.Windows/OptionalFeatureList schemas
Add the source_paths paramter to enable_feature and add_capability functions in dism.rs
- This paramter is passed into the add_capability/enable_feature DISM functions
Resource reference docs updated to include new parameter

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds support for specifying DISM sourcePaths when enabling optional features/capabilities, enabling offline/alternate source installation scenarios.

Changes:

Extend OptionalFeatureList/FeatureOnDemandList inputs/outputs with an optional sourcePaths array.
Validate sourcePaths in set handlers and pass them into DISM calls.
Update resource schemas and docs to document the new property and examples.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
resources/dism_dsc/src/optional_feature/types.rs	Adds `source_paths` field to OptionalFeatureList model.
resources/dism_dsc/src/optional_feature/set.rs	Validates/passes `source_paths` into enable operation; includes in output.
resources/dism_dsc/src/optional_feature/get.rs	Includes `source_paths` in Get output payload.
resources/dism_dsc/src/optional_feature/export.rs	Sets `source_paths: None` in Export output.
resources/dism_dsc/src/feature_on_demand/types.rs	Adds `source_paths` field to FeatureOnDemandList model.
resources/dism_dsc/src/feature_on_demand/set.rs	Validates/passes `source_paths` into add capability; includes in output.
resources/dism_dsc/src/feature_on_demand/get.rs	Includes `source_paths` in Get output payload.
resources/dism_dsc/src/feature_on_demand/export.rs	Sets `source_paths: None` in Export output.
resources/dism_dsc/src/dism.rs	Extends DISM FFI calls to pass SourcePaths/SourcePathCount.
resources/dism_dsc/optionalfeature.dsc.resource.json	Adds `sourcePaths` to resource schema.
resources/dism_dsc/featureondemand.dsc.resource.json	Adds `sourcePaths` to resource schema.
resources/dism_dsc/locales/en-us.toml	Adds localized error string for invalid source path.
docs/reference/resources/Microsoft/Windows/OptionalFeatureList/index.md	Documents `sourcePaths` and updates links.
docs/reference/resources/Microsoft/Windows/OptionalFeatureList/examples/enable-disable-optional-features.md	Adds example using offline source.
docs/reference/resources/Microsoft/Windows/FeatureOnDemandList/index.md	Documents `sourcePaths` and adds link.
docs/reference/resources/Microsoft/Windows/FeatureOnDemandList/examples/install-remove-feature-on-demand.md	Adds example using offline source.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

…ngling-but-non-null pointer

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

SteveL-MSFT

This looks fine to me, @Alex-shearing you tested this locally? @michaeltlombardi can you do a docs pass on this? Thanks.

Alex-shearing · 2026-06-09T13:09:59Z

This looks fine to me, @Alex-shearing you tested this locally? @michaeltlombardi can you do a docs pass on this? Thanks.

Yes, tested successfully on my local. My testing included multiple full removals and re-installs of the features, while disconnected from the internet (with a local SxS file)

SteveL-MSFT · 2026-06-18T16:34:34Z

@Alex-shearing can you resolve the merge conflict?

michaeltlombardi

Requesting some changes mostly centered on updating the JSON Schema to more correctly represent the property (write-only, minimum count, uniqueness).

michaeltlombardi · 2026-06-23T15:39:09Z

+- **Instance properties:** <a id="instance-properties"></a> The following properties are optional.
+  They define the desired state for an instance of the resource.
+
+  - [sourcePaths](#sourcePaths) - The location of the source files to use for installation if 
+    necessary.


I think this is more correctly a write-only property, given that it only affects how the resource behaves during a Set operation.

Instance properties typically represent actual properties of the underlying resource (like the name of the feature and whether it exists) where write-only properties affect how the resource behaves and read-only properties are metadata about the resource that the user can't directly and idempotently manage (like the last write time for a file or the author for a software package).

Suggested change

- **Instance properties:** <a id="instance-properties"></a> The following properties are optional.

They define the desired state for an instance of the resource.

- [sourcePaths](#sourcePaths) - The location of the source files to use for installation if

necessary.

- **Write-only properties:** <a id="write-only-properties"></a> The resource accepts the following

properties that affect its behavior but can't be retrieved for the actual state of an instance.

For more information about read-only properties, see the "Write-only resource properties" section

in [DSC resource properties][aa].

- [sourcePaths](#sourcePaths) - The location of the source files to use for installation if

necessary.

michaeltlombardi · 2026-06-23T15:55:42Z

+<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>
+
+```yaml
+Type       : array
+IsRequired : false
+IsKey      : false
+IsReadOnly : false
+```
+
+</details>
+
+Supplied at the top level of the **Set** operation, indicates the location of the source files to
+use for installation if necessary. The DISM API will search these paths if the feature files are
+not available in the local feature store. See the [feature on demand repository documentation][08]
+for more information on valid sources.
+
+This property is optional and will be omitted from the response if no value is provided.


Suggested change

<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>

```yaml

Type : array

IsRequired : false

IsKey : false

IsReadOnly : false

```

</details>

Supplied at the top level of the **Set** operation, indicates the location of the source files to

use for installation if necessary. The DISM API will search these paths if the feature files are

not available in the local feature store. See the [feature on demand repository documentation][08]

for more information on valid sources.

This property is optional and will be omitted from the response if no value is provided.

<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>

```yaml

Type : array

ItemsType : string

ItemsMinimumCount : 1

ItemsMustBeUnique : true

IsRequired : false

IsKey : false

IsReadOnly : false

IsWriteOnly : true

```

</details>

Indicates where the resource should look for source files to install a feature when the feature

files aren't available in the local feature store for offline systems. Specify this property as an

array of one or more unique strings where each string represents the path to a source file to use.

This property affects how the resource behaves during **Set** operations. It has no affect for any

other resource operations. For more information about valid sources for the DISM API, see the

[`/Enable-Feature` reference for the `dism` command][08].

michaeltlombardi · 2026-06-23T15:57:21Z

+    "sourcePaths": {
+      "type": "array",
+      "items": {
+        "type": "string"
+      }
+    },


Suggested change

"sourcePaths": {

"type": "array",

"items": {

"type": "string"

}

},

"sourcePaths": {

"type": "array",

"items": {

"type": "string"

},

"minItems": 1,

"uniqueItems": true

},

michaeltlombardi · 2026-06-23T16:28:10Z

+- **Instance properties:** <a id="instance-properties"></a> The following properties are optional.
+  They define the desired state for an instance of the resource.


Suggested change

- **Instance properties:** <a id="instance-properties"></a> The following properties are optional.

They define the desired state for an instance of the resource.

- **Write-only properties:** <a id="write-only-properties"></a> The resource accepts the following

properties that affect its behavior but can't be retrieved for the actual state of an instance.

For more information about read-only properties, see the "Write-only resource properties" section

in [DSC resource properties][aa].

michaeltlombardi · 2026-06-23T16:28:49Z

 [06]: ../FeatureOnDemandList/index.md
-[07]: /windows-server/administration/windows-commands/dism/dism-operating-system-package-servicing-command-line-options
+[07]: /windows-hardware/manufacture/desktop/deployment-image-servicing-and-management--dism--command-line-options
+[08]: /windows-hardware/manufacture/desktop/dism-operating-system-package-servicing-command-line-options#enable-feature


Suggested change

[08]: /windows-hardware/manufacture/desktop/dism-operating-system-package-servicing-command-line-options#enable-feature

[08]: /windows-hardware/manufacture/desktop/dism-operating-system-package-servicing-command-line-options#enable-feature

[aa]: ../../../../../concepts/resources/properties.md#write-only-resource-properties

michaeltlombardi · 2026-06-23T16:32:51Z

 [05]: ../../../../../concepts/resources/properties.md#read-only-resource-properties
 [06]: ../OptionalFeatureList/index.md
 [07]: /windows-hardware/manufacture/desktop/features-on-demand-v2--capabilities
+[08]: /windows-hardware/manufacture/desktop/features-on-demand-v2--capabilities?view=windows-11#fod-repositories


Suggested change

[08]: /windows-hardware/manufacture/desktop/features-on-demand-v2--capabilities?view=windows-11#fod-repositories

[08]: /windows-hardware/manufacture/desktop/features-on-demand-v2--capabilities?view=windows-11#fod-repositories

[aa]: ../../../../../concepts/resources/properties.md#write-only-resource-properties

michaeltlombardi · 2026-06-23T16:34:34Z

+<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>
+
+```yaml
+Type       : array
+IsRequired : false
+IsKey      : false
+IsReadOnly : false
+```
+
+</details>
+
+Supplied at the top level of the **Set** operation, indicates the location of the source files to 
+use for installation if necessary. The DISM API will search these paths if the feature files are
+not available in the local feature store. See the [DISM enable feature documentation][08] for more
+information on valid sources.
+
+This property is optional and will be omitted from the response if no value is provided.


Suggested change

<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>

```yaml

Type : array

IsRequired : false

IsKey : false

IsReadOnly : false

```

</details>

Supplied at the top level of the **Set** operation, indicates the location of the source files to

use for installation if necessary. The DISM API will search these paths if the feature files are

not available in the local feature store. See the [DISM enable feature documentation][08] for more

information on valid sources.

This property is optional and will be omitted from the response if no value is provided.

<details><summary>Expand for <code>sourcePaths</code> property metadata</summary>

```yaml

Type : array

ItemsType : string

ItemsMinimumCount : 1

ItemsMustBeUnique : true

IsRequired : false

IsKey : false

IsReadOnly : false

IsWriteOnly : true

```

</details>

Indicates where the resource should look for source files to install a feature when the feature

files aren't available in the local feature store for offline systems. Specify this property as an

array of one or more unique strings where each string represents the path to a source file to use.

This property affects how the resource behaves during **Set** operations. It has no affect for any

other resource operations. For more information about valid sources for the DISM API, see the

[`/Enable-Feature` reference for the `dism` command][08].

michaeltlombardi · 2026-06-23T16:35:36Z

+    "sourcePaths": {
+      "type": "array",
+      "items": {
+        "type": "string"
+      }
    },


Suggested change

"sourcePaths": {

"type": "array",

"items": {

"type": "string"

}

},

"sourcePaths": {

"type": "array",

"items": {

"type": "string"

},

"minItems": 1,

"uniqueItems": true

},

michaeltlombardi · 2026-06-23T16:42:24Z

+                "sourcePaths": {
+                    "type": "array",
+                    "title": "Source paths",
+                    "description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",
+                    "items": {
+                        "type": "string"
+                    }


Suggested change

"sourcePaths": {

"type": "array",

"title": "Source paths",

"description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",

"items": {

"type": "string"

}

"sourcePaths": {

"type": "array",

"writeOnly": true,

"title": "Source paths",

"description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",

"items": {

"type": "string"

},

"minItems": 1,

"uniqueItems": true

michaeltlombardi · 2026-06-23T16:42:55Z

+                "sourcePaths": {
+                    "type": "array",
+                    "title": "Source paths",
+                    "description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",
+                    "items": {
+                        "type": "string"
+                    }


Suggested change

"sourcePaths": {

"type": "array",

"title": "Source paths",

"description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",

"items": {

"type": "string"

}

"sourcePaths": {

"type": "array",

"writeOnly": true,

"title": "Source paths",

"description": "An array of paths to feature files if the files are not available in the local feature store. This is an optional property for set operations and is ignored for get operations.",

"items": {

"type": "string"

},

"minItems": 1,

"uniqueItems": true

Alex-shearing added 6 commits June 5, 2026 19:18

Initial build

91d0ccf

Port to feature on demand

8854661

Change paths to plural, fix schema

ccd1e75

Add item type to schema

1ac5a52

Update docs

9a05ad2

Fix incorrect example output

6f04636

Alex-shearing marked this pull request as ready for review June 5, 2026 10:37

Copilot AI review requested due to automatic review settings June 5, 2026 10:37

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Alex-shearing added 2 commits June 5, 2026 20:43

Fix sourcepath type in examples

66e963a

Fix incorrect typos

6da2c30

Alex-shearing marked this pull request as draft June 5, 2026 10:46

Alex-shearing added 4 commits June 5, 2026 20:47

Fix localisations

88e1e8e

fix dangling pointers

1c25dcf

Remove path validation and let dism handle it

ec8c2da

clarified sourcePaths behaviour in docs

af6aa7c

Alex-shearing marked this pull request as ready for review June 5, 2026 11:16

Alex-shearing requested a review from Copilot June 5, 2026 11:16

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Alex-shearing added 4 commits June 5, 2026 21:43

Change get function to return None for source pathand fix possible da…

b9a8154

…ngling-but-non-null pointer

Remove echo comments from docs

5daaea0

Simplfy documentation wording

8374a06

Fix wording in examples

a8a5cab

Alex-shearing requested a review from Copilot June 5, 2026 11:47

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Alex-shearing added 2 commits June 5, 2026 22:08

Misc changes

7bc06dc

Remove unused translations

3b5a162

SteveL-MSFT approved these changes Jun 8, 2026

View reviewed changes

SteveL-MSFT requested a review from michaeltlombardi June 9, 2026 17:59

michaeltlombardi requested changes Jun 23, 2026

View reviewed changes

		- Instance properties: <a id="instance-properties"></a> The following properties are optional.
		They define the desired state for an instance of the resource.

-- **Instance properties:** <a id="instance-properties"></a> The following properties are optional.
-  They define the desired state for an instance of the resource.
+- **Write-only properties:** <a id="write-only-properties"></a> The resource accepts the following
+  properties that affect its behavior but can't be retrieved for the actual state of an instance.
+  For more information about read-only properties, see the "Write-only resource properties" section
+  in [DSC resource properties][aa].

	[08]: /windows-hardware/manufacture/desktop/dism-operating-system-package-servicing-command-line-options#enable-feature
	[08]: /windows-hardware/manufacture/desktop/dism-operating-system-package-servicing-command-line-options#enable-feature
	[aa]: ../../../../../concepts/resources/properties.md#write-only-resource-properties

Conversation

Alex-shearing commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Alex-shearing commented Jun 9, 2026

Uh oh!

SteveL-MSFT commented Jun 18, 2026

Uh oh!

michaeltlombardi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alex-shearing commented Jun 5, 2026 •

edited

Loading